Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase argument for inset text #1970

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented May 17, 2024

Description

Use a lowercase argument for html rather than uppercase. This goes alongside this PR on NHS Frontend (released).

@edwardhorsford edwardhorsford added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) blocked Work that that cannot be progressed at this moment in time labels May 17, 2024
@edwardhorsford edwardhorsford marked this pull request as draft May 17, 2024 13:56
@edwardhorsford
Copy link
Contributor Author

This can be merged when the next release of NHS Frontend is made and this library updated to use it.

@edwardhorsford edwardhorsford removed the blocked Work that that cannot be progressed at this moment in time label Jun 12, 2024
@edwardhorsford edwardhorsford marked this pull request as ready for review June 12, 2024 11:30
@anandamaryon1 anandamaryon1 merged commit 7095b0a into main Jun 12, 2024
2 checks passed
@anandamaryon1 anandamaryon1 deleted the fix-inset-text-argument branch June 12, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants